search

zWolfrost / Better-Volume-Booster

Volume booster firefox extension that remembers your choices.
https://addons.mozilla.org/addon/better-volume-booster/
MIT License
20 stars 2 forks source link

general bug? #7

Closed jwexus closed 2 months ago

jwexus commented 2 months ago

there seems to be a general bug with firefox sound boosters that videos wont play for some reason on sites. would it be hard to add exclude sites? i have confirmed that the bug happens with sound boosters with disabling all extentions and only replicated on sound boosters including this one! thank you for taking your time to make this btw.

zWolfrost commented 2 months ago

It wouldn't be hard to exclude some sites, but I think it would be pretty cumbersome to manually exclude them one by one.

As a workaround, you can try to go in the extension settings and disabling the permission to read all sites, and then enabling the permission on only the ones that work/you need.

Giving me an example of website that doesn't work would be pretty helpful though, especially if it doesn't use javascript to play audio (spotify and netflix are already known to not work, for example), so that I can try troubleshooting.

Unfortunately the firefox extension API has some missing functions relative to chrome (probably for privacy's sake, so you can't just possibly tunnel all the audio coming from the browser to some 3rd party server etc.). That's why most, if not all audio boost extensions, don't work on websites like that.

jwexus commented 2 months ago

tiktok is one of the sites that does this. also after the video ( i thought i did it) i checked if i disabled the permission to all sites and it wasnt disabled so i tried again. same result. even though i allow it on the site i want only it causes problems while being enabled as an extension. i had another extension i was using before for firefox which made things even worse. i was not able to watch any kind of video when it was enabled outside of youtube and facebook. if its going to help any kind of troubleshooting the name of the said extension is "600% Sound Volume for firefox"

https://github.com/user-attachments/assets/f3a6a0a6-7dcc-419f-a410-1d8fa9233257

(sorry for the stupid gestures in the video)

jwexus commented 2 months ago

2 oh it happened here too xD

zWolfrost commented 2 months ago

About tiktok, you're right, it should work there. In fact, I think I managed to fix it after a little troubleshooting. I would be really happy if you could test this new version on tiktok (and other website that do the same, as I don't know if it's just a tiktok-specific fix, and I don't know any other websites that don't play media at all).

You can download the new version in this zip file. Then, after you extracted it, to load it you can do: Manage Extension > Debug Add-ons > Load Temporary Add-on > Select "manifest.json" in the extracted folder.

When you go on tiktok, check the "Send cookies" checkbox in the pop-up and let me know if it works.

About the error in this very github page, I don't really know why that happened. For me, that video works fine and I can't manage to reproduce your error :P

better_volume_booster-1.11.2.zip

jwexus commented 2 months ago

Screenshot_1 maybe the same solution fixed it for the other problem too. tiktok works fine with the "send cookies" pop up and the other site works fine that had the same error that was in github.

https://github.com/user-attachments/assets/262fb2a1-90fa-4177-bee0-42a2c1e2d757

zWolfrost commented 2 months ago

I'm happy to hear that. I will release this fix in the near future, maybe with some improvements.

jwexus commented 2 months ago

im glad! its an excellent extension btw. my fav so far so im actually happy

zWolfrost commented 2 months ago

Just for the record, to access the "send cookies" button in the just released version you need to go into the options and set "Send cookies in media requests" to "ask" (I figured always showing it would get annoying for people who don't want to use it)