Bump node-fetch from 2.6.1 to 3.1.1

[dependabot[bot]]

Bumps node-fetch from 2.6.1 to 3.1.1.

Release notes

Sourced from node-fetch's releases.

v3.1.1

Security patch release

Recommended to upgrade, to not leak sensitive cookie and authentication header information to 3th party host while a redirect occurred

What's Changed

• core: update fetch-blob by @​jimmywarting in node-fetch/node-fetch#1371
• docs: Fix typo around sending a file by @​jimmywarting in node-fetch/node-fetch#1381
• core: (http.request): Cast URL to string before sending it to NodeJS core by @​jimmywarting in node-fetch/node-fetch#1378
• core: handle errors from the request body stream by @​mdmitry01 in node-fetch/node-fetch#1392
• core: Better handle wrong redirect header in a response by @​tasinet in node-fetch/node-fetch#1387
• core: Don't use buffer to make a blob by @​jimmywarting in node-fetch/node-fetch#1402
• docs: update readme for TS @​types/node-fetch by @​adamellsworth in node-fetch/node-fetch#1405
• core: Fix logical operator priority to disallow GET/HEAD with non-empty body by @​maxshirshin in node-fetch/node-fetch#1369
• core: Don't use global buffer by @​jimmywarting in node-fetch/node-fetch#1422
• ci: fix main branch by @​dnalborczyk in node-fetch/node-fetch#1429
• core: use more node: protocol imports by @​dnalborczyk in node-fetch/node-fetch#1428
• core: Warn when using data by @​jimmywarting in node-fetch/node-fetch#1421
• docs: Create SECURITY.md by @​JamieSlome in node-fetch/node-fetch#1445
• core: don't forward secure headers to 3th party by @​jimmywarting in node-fetch/node-fetch#1449

New Contributors

• @​mdmitry01 made their first contribution in node-fetch/node-fetch#1392
• @​tasinet made their first contribution in node-fetch/node-fetch#1387
• @​adamellsworth made their first contribution in node-fetch/node-fetch#1405
• @​maxshirshin made their first contribution in node-fetch/node-fetch#1369
• @​JamieSlome made their first contribution in node-fetch/node-fetch#1445

Full Changelog: https://github.com/node-fetch/node-fetch/compare/v3.1.0...v3.1.1

v3.1.0

What's Changed

• fix(Body): Discourage form-data and buffer() by @​jimmywarting in node-fetch/node-fetch#1212
• fix: Pass url string to http.request by @​serverwentdown in node-fetch/node-fetch#1268
• Fix octocat image link by @​lakuapik in node-fetch/node-fetch#1281
• fix(Body.body): Normalize Body.body into a node:stream by @​jimmywarting in node-fetch/node-fetch#924
• docs(Headers): Add default Host request header to README.md file by @​robertoaceves in node-fetch/node-fetch#1316
• Update CHANGELOG.md by @​jimmywarting in node-fetch/node-fetch#1292
• Add highWaterMark to cloned properties by @​davesidious in node-fetch/node-fetch#1162
• Update README.md to fix HTTPResponseError by @​thedanfernandez in node-fetch/node-fetch#1135
• docs: switch url to URL by @​dhritzkiv in node-fetch/node-fetch#1318
• fix(types): declare buffer() deprecated by @​dnalborczyk in node-fetch/node-fetch#1345
• chore: fix lint by @​dnalborczyk in node-fetch/node-fetch#1348
• refactor: use node: prefix for imports by @​dnalborczyk in node-fetch/node-fetch#1346
• Bump data-uri-to-buffer from 3.0.1 to 4.0.0 by @​dependabot in node-fetch/node-fetch#1319
• Bump mocha from 8.4.0 to 9.1.3 by @​dependabot in node-fetch/node-fetch#1339
• Referrer and Referrer Policy by @​tekwiz in node-fetch/node-fetch#1057
• Add typing for Response.redirect(url, status) by @​c-w in node-fetch/node-fetch#1169
• chore: Correct stuff in README.md by @​Jiralite in node-fetch/node-fetch#1361
• docs: Improve clarity of "Loading and configuring" by @​serverwentdown in node-fetch/node-fetch#1323
• feat(Body): Added support for BodyMixin.formData() and constructing bodies with FormData by @​jimmywarting in node-fetch/node-fetch#1314

... (truncated)

Changelog

Sourced from node-fetch's changelog.

Changelog

All notable changes will be recorded here.

The format is based on Keep a Changelog, and this project adheres to Semantic Versioning.

What's Changed

• core: update fetch-blob by @​jimmywarting in node-fetch/node-fetch#1371
• docs: Fix typo around sending a file by @​jimmywarting in node-fetch/node-fetch#1381
• core: (http.request): Cast URL to string before sending it to NodeJS core by @​jimmywarting in node-fetch/node-fetch#1378
• core: handle errors from the request body stream by @​mdmitry01 in node-fetch/node-fetch#1392
• core: Better handle wrong redirect header in a response by @​tasinet in node-fetch/node-fetch#1387
• core: Don't use buffer to make a blob by @​jimmywarting in node-fetch/node-fetch#1402
• docs: update readme for TS @​types/node-fetch by @​adamellsworth in node-fetch/node-fetch#1405
• core: Fix logical operator priority to disallow GET/HEAD with non-empty body by @​maxshirshin in node-fetch/node-fetch#1369
• core: Don't use global buffer by @​jimmywarting in node-fetch/node-fetch#1422
• ci: fix main branch by @​dnalborczyk in node-fetch/node-fetch#1429
• core: use more node: protocol imports by @​dnalborczyk in node-fetch/node-fetch#1428
• core: Warn when using data by @​jimmywarting in node-fetch/node-fetch#1421
• docs: Create SECURITY.md by @​JamieSlome in node-fetch/node-fetch#1445
• core: don't forward secure headers to 3th party by @​jimmywarting in node-fetch/node-fetch#1449

New Contributors

• @​mdmitry01 made their first contribution in node-fetch/node-fetch#1392
• @​tasinet made their first contribution in node-fetch/node-fetch#1387
• @​adamellsworth made their first contribution in node-fetch/node-fetch#1405
• @​maxshirshin made their first contribution in node-fetch/node-fetch#1369
• @​JamieSlome made their first contribution in node-fetch/node-fetch#1445

Full Changelog: https://github.com/node-fetch/node-fetch/compare/v3.1.0...v3.1.2

3.1.0

What's Changed

• fix(Body): Discourage form-data and buffer() by @​jimmywarting in node-fetch/node-fetch#1212
• fix: Pass url string to http.request by @​serverwentdown in node-fetch/node-fetch#1268
• Fix octocat image link by @​lakuapik in node-fetch/node-fetch#1281
• fix(Body.body): Normalize Body.body into a node:stream by @​jimmywarting in node-fetch/node-fetch#924
• docs(Headers): Add default Host request header to README.md file by @​robertoaceves in node-fetch/node-fetch#1316
• Update CHANGELOG.md by @​jimmywarting in node-fetch/node-fetch#1292
• Add highWaterMark to cloned properties by @​davesidious in node-fetch/node-fetch#1162
• Update README.md to fix HTTPResponseError by @​thedanfernandez in node-fetch/node-fetch#1135
• docs: switch url to URL by @​dhritzkiv in node-fetch/node-fetch#1318
• fix(types): declare buffer() deprecated by @​dnalborczyk in node-fetch/node-fetch#1345
• chore: fix lint by @​dnalborczyk in node-fetch/node-fetch#1348
• refactor: use node: prefix for imports by @​dnalborczyk in node-fetch/node-fetch#1346
• Bump data-uri-to-buffer from 3.0.1 to 4.0.0 by @​dependabot in node-fetch/node-fetch#1319
• Bump mocha from 8.4.0 to 9.1.3 by @​dependabot in node-fetch/node-fetch#1339
• Referrer and Referrer Policy by @​tekwiz in node-fetch/node-fetch#1057
• Add typing for Response.redirect(url, status) by @​c-w in node-fetch/node-fetch#1169

... (truncated)

Commits

• 36e47e8 3.1.1 release (#1451)
• 5304f3f Don't change relative location header on manual redirect (#1105)
• f5d3cf5 fix(Headers): don't forward secure headers to 3th party (#1449)
• f2c3d56 Create SECURITY.md (#1445)
• 4ae3538 core: Warn when using data (#1421)
• 41f53b9 fix: use more node: protocol imports (#1428)
• f674875 ci: fix main branch (#1429)
• 1493d04 core: Don't use global buffer (#1422)
• eb33090 Chore: Fix logical operator priority (regression) to disallow GET/HEAD with n...
• 7ba5bc9 update readme for TS @​type/node-fetch (#1405)
• Additional commits viewable in compare view

Maintainer changes

This version was pushed to npm by endless, a new releaser for node-fetch since your current version.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/za419/CadenceBot/network/alerts).

[JunhaoSLi]

It seems like node-fetch has moved to being an ESM only package with the v3 major update. They do suggest sticking with v2 until the project is ready to move to ESM. I'm not entirely sure what this means but what are your thoughts @za419?

[za419]

Hmm. Okay... Well, I did look at it. ESM-only (ECMAScript Module?) means we can't require it anymore, we'd have to do something like import fetch from 'node-fetch'. Which isn't that bad an idea I suppose.... But still, I'd want to change all the imports, and then the config imports look weird and we might have to explicitly JSON.parse them. Grr..

The only other potential consequence I see from the link is that they bump the version requirement to Node 12.20, which we inherit. But we document support for 12.0+ - That shouldn't be a big deal, it's just a minor version bump and we should run latest anyway - Prod is on 15.14.

So, options:

1. Bump version, also alter README to show minimum Node version of 12.20 (or greater if we want), change bot.js to use import instead of require and possibly fix the config importing, regression test (1 PR for all, changes brought into this PR)
2. Kill this PR and bump to the latest 2.x of node-fetch. Again, 1PR and regression test.
3. Kill this PR, and since we only use fetch in two (nearly identical) cases to fetch nowplaying information, just remove our dependency on it and refactor around request.get to better align with the other APIs we consume (even know nowplaying is weird anyway since @kenellorando chose to use JSONP here and we don't consume it that way).

What do you think?

[JunhaoSLi]

I guess I'll try to see how much of a pain option 1 is and if that doesn't work I'll try option 3. I'm getting the impression that ECM is the future and something that would need to be dealt with at some point possibly? So I'll try option 1 first.

[za419]

Sounds good to me.

Yeah, ECM is definitely the future, the question is just how much we care about whether we deal with it. Plenty of software does outdated things fine...

But hey, I don't mind using new and better stuff. Go for it!

[dependabot[bot]]

Superseded by #97.