za419 / CadenceBot

A Discord bot for Cadence Radio
MIT License
2 stars 1 forks source link

Upgrade request dependency #98

Open za419 opened 2 years ago

za419 commented 2 years ago

request as installed depends on a version of json-fetch which is vulnerable to RCE on user-provided JSON (CVE-2021-3918).

This is currently not too much of an attack on CadenceBot (we're low-risk, we trust the IA's config inputs, and we trust the API server), but once we allow live reconfiguration by non-IAs we need to harden against a server admin attempting to inject code that could have wider impact.

Therefore, upgrade request to a version whose dependency tree does not include a version of json-fetch before 0.4.0.

This issue must be resolved before merge of a fix for #45.