zaach / jison

Bison in JavaScript.
http://jison.org
4.34k stars 448 forks source link

Fix throwing of parseError #319

Closed polybuildr closed 8 years ago

polybuildr commented 8 years ago

The constructor is set to new Error(), instead set it to just Error.

Fixes #318.

AlexGustafsson commented 8 years ago

Made the plugin usable again. Hoping for @zaach to merge this soon.

RubenVerborgh commented 8 years ago

But now thrown errors are no longer instances of Error. This is not desired either.

I suggest to have a look at this thread on how to properly extend Error.

RubenVerborgh commented 8 years ago

Fixed in #325.