Support globs and fix some issues

zaach / jsonlint

A JSON parser and validator with a CLI.

http://zaach.github.com/jsonlint/

1.93k stars 417 forks source link

Support globs and fix some issues #104

Open poppinlp opened 6 years ago

poppinlp commented 6 years ago

Hi. @zaach I use this package in my work recently. I find the open issues are also my problem. So i wanna do some fix.

Support globs input not only files (I found this issue which i agreed)
Will lint all input files not just stoped when error occur since supports globs now.
Use commander instead of nomnom since it's deprecated and also is for this issue.
Fix display errors from stdin when quiet option set from this issue.

I haven't change too much code to make it easier to accept. Wait for your reply. Thanks. :)

poppinlp commented 6 years ago

@zaach Hi, are you there~ :) Seems this repo is not on maintained?

fedorov commented 6 years ago

I have the same issue. Time to look for another json linter ...

poppinlp commented 6 years ago

@fedorov Bad news :( Do you have any recommended ones?

fedorov commented 6 years ago

@poppinlp I am not sure about the linter, but @jcfr had that idea to use the following in https://github.com/QIICR/dcmqi/pull/333, which works for me, so I am getting rid of the jsonlint dependency.

python -c "import json; json.load(open('file.json'))"

zaach commented 6 years ago

Hey @poppinlp, I did a minor release to fix the nomnom issue. Do you mind rebasing this PR?

poppinlp commented 6 years ago

@zaach Hi. Sorry for my late reply. I've done that rebase. :)

poppinlp commented 6 years ago

@zaach Hi. Dose this PR ready and should i go on other issues for this repo?

poppinlp commented 6 years ago

@zaach Hi. Just a friendly remind~ And if you don't mind, i'll send more PR for this repo~ :)

aerostitch commented 6 years ago

It would be so nice to finally have that one merged and released! :)

pkuczynski commented 5 years ago

@zaach any chance to merge this in? Support for globs is really needed...