zaach / jsonlint

A JSON parser and validator with a CLI.
http://zaach.github.com/jsonlint/
1.93k stars 417 forks source link

`jsonlint --version` returns nonzero exit status, indicating failure #122

Open evolutics opened 4 years ago

evolutics commented 4 years ago

For JSON Lint 1.6.3, running jsonlint --version returns exit code 1, which is commonly used to indicate failure.

Instead, I'd expected jsonlint --version to return exit code 0, indicating success, as this seems normal usage of the utility to me. This is also recommended by the GNU Coding Standards on --version in general.

Instructions to reproduce this:

docker run -it --rm alpine:3.10.3
/ # apk add npm=10.16.3-r0
/ # npm install jsonlint@1.6.3 -g
/ # jsonlint --version
1.6.3
/ # echo "$?"
1
stefancrain commented 4 years ago

Temporary workaround : use jsonlint --version || true

prantlf commented 4 years ago

My fork (@prantlf/jsonlint) exits with zero in this case. More of a side-effect after switching to commander as command-line argument parser, which behaves like that by default...

Friend-LGA commented 1 year ago

3 years later, still version 1.6.3 and still it's failing on jsonlint --version Maybe it's time to bump up the version?