zaach / jsxgettext

Extract gettext calls from JavaScript, EJS, and other template formats.
Mozilla Public License 2.0
105 stars 56 forks source link

Handle parameters in handlebars #113

Closed stevebartholomew closed 7 years ago

stevebartholomew commented 8 years ago

What does this do?

Adds support for parameters when using gettext in handlers in handlebars templates:

{{ gettext "My name is %s" person.name }}

Ok - so what happens if you use that now?

Parsing hangs - indefinitely against my code - and it times out if you try this in the tests.

Why do you want this?

To bring the parsing of handlerbars templates inline with that of other JS code.

I've been running off my good friend Tim Peat's branch from a few years ago: https://github.com/timpeat/jsxgettext - this is basically a port of that. However, I'm now using ES6 in parts of the project so I'd like to start using the main package.

Thanks!!

lxhunter commented 8 years ago

+1