zaach / jsxgettext

Extract gettext calls from JavaScript, EJS, and other template formats.
Mozilla Public License 2.0
105 stars 56 forks source link

Context implemenation and some test cases #116

Open sameercaresu opened 7 years ago

sameercaresu commented 7 years ago

This is the implementation of pgettext and npgettext mentioned in https://github.com/zaach/jsxgettext/issues/95.

I have added some test cases for pgettext and npgettext. Other tests, that I have not modified, are passing the tests as well.

Please let me know if you have any comments.

sameercaresu commented 7 years ago

I have added implementation of dgettext, dngettext, dpgettext and dnpgettext. If domain is used it is ignored during extraction.

ArmorDarks commented 7 years ago

Wow, that's nice! Thanks!

sameercaresu commented 7 years ago

Any chance this could go into next release? Thanks.

sameercaresu commented 7 years ago

Hi I have made the requested changes. Please let me know if there's more changes needed.