search

zaach / jsxgettext

Extract gettext calls from JavaScript, EJS, and other template formats.
Mozilla Public License 2.0
105 stars 56 forks source link

Remove requirement to have comments in pre-existing po template #84

Closed beck closed 9 years ago

beck commented 9 years ago

Was throwing errors when using a pot without comments.

I often use --no-location to helps keep code diffs sane.

BYK commented 9 years ago

CAN I HAZ TESTS PLZ? KTHXBAI :)

ozten commented 9 years ago

@BYK I agree, adding a commit with tests would be awesome, but the change is very straightforward and can only improve the codebase. r+

ozten commented 9 years ago

@zaach Sorry! I thought this was my repo. <3

beck commented 9 years ago

@ozten no need to fret, tests added: https://github.com/zaach/jsxgettext/pull/85

BYK commented 9 years ago

@ozten - I'm so MAD right now :P Inspector Gadget MAD

ozten commented 9 years ago

Awesome!