Closed vrouet closed 9 years ago
I've noticed that one test if failing, but I checked on the master version and it does fail as well, so it's not something I broke ;)
First of all this is great! Thank you since we have been wanting this for quite some time now. I have a few requests though:
ngettext
usage. Adding tests may cover this.Fixes #51
Thanks for your reviews, I will definitely add some tests and doc for that, I made the pull request first basically to see if my approach was fitting your standards, and did rthings quickly because I needed to tel my dev team what to use for i18n on our project. I will update soon
Ok, I have taken your comments into account, added some notes, integrated the plural functions to all of the relevant test cases, and squashed my commits
And rebase to get tests fixed :)
Alright, rebase is done. Nice to see the whole test suite passing ;)
Alright, rebase is done. Nice to see the whole test suite passing ;)
Definitely. You triggered me to do it :)
Final thing before merge: fix those %s
lines in the README please?
OK now
This adds basic plural forms extraction, it suits my need well, it'd be great to have merged. I'm sure there are stuff I didn't think about and that would need fixing before, so please comment on this.