search

zabaras / transformer-physx

Transformers for modeling physical systems
https://zabaras.github.io/transformer-physx/
MIT License
127 stars 32 forks source link

About the lorenz system #4

Open shuizidesu opened 2 years ago

shuizidesu commented 2 years ago

Hello!

Thanks for your exciting work!

I'm confused about the result of the Lorenz system. The paper shows that the Lorenz system's prediction results are perfect, but I can't reproduce it based on the currently provided code. Moreover, the run results provided in Colab are also not great enough (states error stay 18). I really want to know what caused this.

Thank you very much!

ruohai0925 commented 1 year ago

Hi Nick, @NickGeneva, any follow up for this question?

keyspire commented 8 months ago

I could not clarify why the code does not work without this line, but I found that embedder.eval() was not written in the function embed_data in the dataset_lorenz.py. This causes NotImplementedError in the dataset_phys.py. Is this related to the issue?