zabaras / transformer-physx

Transformers for modeling physical systems
https://zabaras.github.io/transformer-physx/
MIT License
127 stars 32 forks source link

Delete is True in the following line? #5

Open ruohai0925 opened 1 year ago

ruohai0925 commented 1 year ago

Maybe mask0 should be a tensor not a bool value. So we need to delete "is True".

https://github.com/zabaras/transformer-physx/blob/4da0954cb2a47c1004473e29ae7b952a7289187d/trphysx/embedding/embedding_cylinder.py#L133

ruohai0925 commented 1 year ago

Or use == True