search

zabartcc / ui

2 stars 4 forks source link

[BUG] Controller Dashboard Links Not Working #59

Closed cdconn00 closed 6 months ago

cdconn00 commented 6 months ago

Describe the bug

To Reproduce

Steps to reproduce the behavior:

  1. Go to the controller dashboard.

  2. Click join discord

  3. Go to the controller dashboard.

  4. Click Link Discord.

Expected behavior

  1. Link to vatusa should take you to the VATUSA profile page.
  2. Link to join discord should be a valid discord invite.

System Information (please complete the following information):

Additional context

cdconn00 commented 6 months ago

Triaged, FEND issue, moving to UI project.

cdconn00 commented 6 months ago

"Link Discord Button" operates correctly when the user is logged into VATUSA, otherwise it redirects to the homepage.

This is an issue with the VATUSA site that should be opened with VATUSA -- won't fix.

cdconn00 commented 6 months ago

Make the discord link a env var to stop need for code updates when it changes: https://discord.gg/zabartcc

cdconn00 commented 6 months ago

The environment variable would require us to write infra code to accommodate ... recommend we instead store this information in the DB and make a backlog item to allow it to be configured by admins.

cdconn00 commented 6 months ago

Since we are prioritizing getting things done before a rewrite, going to save making the link dynamic for another day. Link fixed.