search

zabbix-community / helm-zabbix

Helm chart for Zabbix
https://artifacthub.io/packages/helm/zabbix-community/zabbix
Apache License 2.0
79 stars 45 forks source link

feat(zabbix): add externalTrafficPolicy to zabbixserver service #11

Closed tomsozolins closed 1 year ago

tomsozolins commented 1 year ago

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

sa-ChristianAnton commented 1 year ago

Hi!

Thanks for your contribution! Could you please upgrade the version of the chart to 3.3.2 in Chart.yaml and add the new value you have introduced into the values.yaml? Afterwards, please regenerate the documenation as described here.

Thanks

aeciopires commented 1 year ago

Hello @tomsozolins and @sa-ChristianAnton!

I have this Pull Request opened https://github.com/zabbix-community/helm-zabbix/pull/10. If it merged before, will need change the version chart again and will need to solved possible conflicts.

sa-ChristianAnton commented 1 year ago

...and exactly that happened now. Please update version to 3.4.1.

tomsozolins commented 1 year ago

@aeciopires Hello! I'm quite busy currently to make the changes. Feel free to merge these changes into your existing pull requests if you are about to release or i will do it later when have time.

aeciopires commented 1 year ago

Hello @tomsozolins!

Thanks for your contribution!

@sa-ChristianAnton maked others changes in others PRs. Could you solve the conflicts? Could you bump chart version for 3.4.2? Colud you add the new value you have introduced into the values.yaml Could run helm-docs command? Instructions here.

sa-ChristianAnton commented 1 year ago

Pulled changes made by tomsozolins in PR #11 into this PR (adding quote statements to annotations) and updated version and documentation. @aeciopires could you please review?