search

zabbix-community / helm-zabbix

Helm chart for Zabbix
https://artifacthub.io/packages/helm/zabbix-community/zabbix
Apache License 2.0
83 stars 48 forks source link

fix(zabbix): service annotation templating - unable to decode json #13

Closed tomsozolins closed 1 year ago

tomsozolins commented 1 year ago

…annot unmarshal bool into Go struct field

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

Helm templating fails when adding annotation: service.beta.kubernetes.io/aws-load-balancer-cross-zone-load-balancing-enabled: "true"

aeciopires commented 1 year ago

Hi @tomsozolins!

Thanks for your contribution!

@sa-ChristianAnton maked others changes in others PRs. Could you solve the conflicts? Could you bump chart version for 3.4.2? Could run helm-docs command? Instructions here.

sa-ChristianAnton commented 1 year ago

Closing this PR. Pulled changes made here into PR #11