feat: add serviceaccount

zabbix-community / helm-zabbix

Helm chart for Zabbix

https://artifacthub.io/packages/helm/zabbix-community/zabbix

Apache License 2.0

77 stars 45 forks source link

feat: add serviceaccount #72

Closed syphernl closed 4 months ago

syphernl commented 4 months ago

What this PR does / why we need it:

Adds a configurable ServiceAccount to the chart.

Which issue this PR fixes

fixes #70

Special notes for your reviewer:

Checklist

[x] DCO signed
[ ] Chart Version bumped
[x] Variables are documented in the README.md

syphernl commented 4 months ago

@aeciopires Changes applied.

syphernl commented 4 months ago

For some reason I am still seeing that the ha cleanup job uses the default SA rather than the configured one, this needs to be looked into.

syphernl commented 4 months ago

@aeciopires

I kept the PR's separate because they were two different things (but I have a branch I am currently testing both changes on. I could also create a PR based off that and close the other ones. Added SA for Postgres + Proxy as well.

aeciopires commented 4 months ago

Hi @syphernl

I merged a PR that was pending, but I haven't published a version yet... I'll wait for your changes...

Could you synchronize your 2 PRs with the master branch to get my changes and correct any conflicts?

syphernl commented 4 months ago

Done

aeciopires commented 4 months ago

Wonder! It's great this way. I will do the merge and a few more small adjustments and publish the new version of the chart today. Here in Brazil it is early afternoon.

Thank you for your contribution