feat: add more customization for labels

zabbix-community / helm-zabbix

Helm chart for Zabbix

https://artifacthub.io/packages/helm/zabbix-community/zabbix

Apache License 2.0

77 stars 45 forks source link

feat: add more customization for labels #73

Closed syphernl closed 4 months ago

syphernl commented 4 months ago

What this PR does / why we need it:

Adds:

global.commonLabels to globally add labels to all resources
deploymentLabels and containerLabels to add labels to Agent, Server, Web & WebService

Which issue this PR fixes

fixes #71

Special notes for your reviewer:

Checklist

[X] DCO signed
[ ] Chart Version bumped
[X] Variables are documented in the README.md

syphernl commented 4 months ago

@aeciopires I made the requested changes.

aeciopires commented 4 months ago

Hi @syphernl

I merged a PR that was pending, but I haven't published a version yet... I'll wait for your changes...

Could you synchronize your 2 PRs with the master branch to get my changes and correct any conflicts?

syphernl commented 4 months ago

I pulled in the changes of master into this branch. No conflicts to resolve.

I can pick up further changes next week, or feel free to add these yourself 😄

aeciopires commented 4 months ago

Wonder! It's great this way. I will do the merge and a few more small adjustments and publish the new version of the chart today. Here in Brazil it is early afternoon.

Thank you for your contribution