search

zabbix-tools / g2z

Write Zabbix modules in Go!
Other
56 stars 9 forks source link

update to zabbix 3.x #6

Closed hamsterksu closed 8 years ago

hamsterksu commented 8 years ago

update headers to zabbix 3.x

cavaliercoder commented 8 years ago

Thanks for raising this.

Zabbix v3 broke module API compatibility with v2. They're currently working to resolve this in ZBX-10428.

If I accept your pull request, unfortunately this module will no longer work with Zabbix v2. I'm stuck for ideas in the mean time, but can you think of any way we could publish this package with v2 and v3 compatibility?

hamsterksu commented 8 years ago

Hi @cavaliercoder, i see 2 possible ways how to solve version issue

  1. add some ifdef to header files. but i don't like this way.
  2. create 2 different branches(v2.x, v3.x) in project and use http://gopkg.in to resolve versions. seems it's very easy solution and very popular in golang world
cavaliercoder commented 8 years ago

Cool I like that second option. I'll organise that, accept your PR and update documentation in the next few days.

cavaliercoder commented 8 years ago

I've created gopkg.in links and merged your PR into the v3 branch. README has been updated with install instructions for v3.

Thanks very much for this :)