search

zabbly / incus

Incus package repository
176 stars 14 forks source link

Consider creating `incus` system user as part of package #14

Closed f-bn closed 7 months ago

f-bn commented 7 months ago

Hello,

During some tests of these packages, I could see that there is some groups created for Incus, but there is no incus system user created for sub-processes such as dnsmasq or QEMU. Therefore, these processes uses nobody user for their exec, I was a bit surprised at first coming from LXD where there is a native lxd user. After looking in the Incus source code, nobody user is indeed used if there is no incus user present on the system. In fact, I think this doesn't change anything, I just think this is a bit cleaner from a system administration perspective.

WDYT ? I can prepare a PR if needed :)

stgraber commented 7 months ago

Ah yeah, that'd absolutely make sense, a PR would be very much appreciated!

f-bn commented 7 months ago

Alright, I will send a PR soon :)

stgraber commented 7 months ago

Thanks!

broizter commented 7 months ago

Will people who installed Incus before this commit have to create the user manually or will a package upgrade do this?

stgraber commented 7 months ago

The package update will do it