search

zabbly / incus

Incus package repository
176 stars 14 forks source link

Issue launching instances from incus-ui-dashboard #36

Closed sebastiaoLa closed 3 months ago

sebastiaoLa commented 3 months ago

When I try to launch a instance using a locally crafted image it returns me an error

" Image not provided for instance creation"

Screenshot: Screenshot 2024-04-10 at 14-43-41 incus2 netbird selfhosted Incus UI image

This is a fresh debian12 install and a fresh (yesterday) incus install

I can launch this image using incus launch

stgraber commented 3 months ago

What's that image? Is that something you selected from the remote image server or a local image?

sebastiaoLa commented 3 months ago

it's a local image, I've created it using incus publish on one of my instances

sebastiaoLa commented 3 months ago

Do you think we can have a repo with the patches somewhere to iterate on or is there something on lxd's ui license that prevents it?

stgraber commented 3 months ago

I'll take a look, it's likely an issue with handling of local images. Assuming that it's not something I broke with my changes, then it's something that should be reported to LXD UI so they can sort it out on their end. But given it's a part of the UI which had to be altered for Incus, it's quite possible that I broke it :)

stgraber commented 3 months ago

Looks like LXD UI 0.8 should be fixing this issue, I'll work on porting our patches to that version now.

stgraber commented 3 months ago

@edlerd hey, looks like you fixed most of the local image usage with 0.8, but I'm still seeing an issue when the image is of type VM. For some reason the drop-down doesn't adjust to select VM in that case (as it does with remote images), so creating the instance then fails because LXD/Incus is asked to create a container instance from a VM image.

Should be pretty easy to reproduce by coping a VM image locally and then attempting to use that to create a new instance.

edlerd commented 3 months ago

@edlerd hey, looks like you fixed most of the local image usage with 0.8, but I'm still seeing an issue when the image is of type VM. For some reason the drop-down doesn't adjust to select VM in that case (as it does with remote images), so creating the instance then fails because LXD/Incus is asked to create a container instance from a VM image.

Thanks for the pointer, I'll take a look at this shortly.

stgraber commented 3 months ago

Pushed 0.8 to daily now so that should close this issue, will pick up the LXD UI fix for the VM case when that shows up :)

edlerd commented 3 months ago

This should fix it: https://github.com/canonical/lxd-ui/pull/743

stgraber commented 3 months ago

thanks @edlerd !