search

zabbly / incus

Incus package repository
Apache License 2.0
242 stars 19 forks source link

broken patch - Source changed: li to SideNavigationItem #60

Closed zarac closed 1 month ago

zarac commented 1 month ago

https://github.com/zabbly/incus/blob/68f7acb33c64cc98b17b41eba12563032a8e232c/patches/ui-canonical-0002-Update-navigation.patch#L22

https://github.com/canonical/lxd-ui/commit/99079c3bdf471d6821c0c75c74e6f4dddf9df526

stgraber commented 1 month ago

Not sure what that issue is about.

If it's the the patches no longer apply to current lxd-ui, then that's fine, we don't patch the current lxd-ui during our builds.

stgraber commented 1 month ago

Saw the title now, so yeah, we don't apply our patches in the current version of lxd-ui.

zarac commented 1 month ago

@stgraber Alrighty. Thanks!

PS/FYI This was in regards to the AUR build. (It applies the patches, but has for now been kept back to 0.12 in waiting for new patches. There's now a comment there rerferring to here).

LevitatingBusinessMan commented 1 month ago

So will the patches be updated to reflect the change in lxd-ui 0.13? And thus will incus-ui-canonical be updated to 0.13? Or will it be kept at version 0.12 for the foreseeable future.

stgraber commented 1 month ago

It will eventually be updated to 0.13 but it's not a high priority thing for us.