search

zabealbe / can-cicd

Automate the managment of your CAN BUS
Other
5 stars 4 forks source link

Some Bugs #56

Closed simoneruffini closed 3 years ago

simoneruffini commented 3 years ago

1) Includes in header files of naked_generator/*/c/*.c are not correct since they reference /out/ that in the build branch is not existing. And the reference path is not working, at least from our point of view, e.g: in Secondary.c

#include "Secondary.h"
#include "../../../../includes_generator/out/Secondary/ids.h"

We have 4 go back one dir while if I compile my code the number of go backs is just 3: 1 to go back from the file too the /Secondary folder,1 to go to /naked_generator and the last one to /can-cicd and from that i can use: includes_generator/out/Secondary/ids.h". Hence my full path is: #include "../../../includes_generator/BMSinternal/ids.h"

2) The new functions networkname_msgname_from_id() are not included in networkname.h thus they are not available to the end user. Please add the prototype in the header file.

zabealbe commented 3 years ago

This is a problem that is the manifestation of a more fundamental one, the solution is to keep the modules indipendent. The fix will be pushed soon.

zabealbe commented 3 years ago

opened a new issue https://github.com/eagletrt/can-cicd/issues/60