search

zabel-xyz / plsql-language

plsql-language for vscode
MIT License
78 stars 29 forks source link

Go to Symbol with name in quotes #62

Closed khatibMarwan closed 5 years ago

khatibMarwan commented 5 years ago

Hi, I've just added the extension and it works fine, but when tested Go to definition or go to symbol, it doesn't recognize procedure or function name if surrounded by double quotations.

I am using ODP.NET on Visual Studio which generates script files with qualified object names, e.g., PROCEDURE "HELLO".

Is there any configuration to support that? or current version (1.6.5) doesn't support it?

Thanks

zabel-xyz commented 5 years ago

Give me an example of what exactly doesn't work, in order to fix regExpParser.

khatibMarwan commented 5 years ago

sample.zip

Attached sample file contains a procedure "VALIDATE_DATES". FUNCTION "APPOINTMENT_BYCATEGORY" invokes VALIDATE_DATES(R1, R2, ISTIME, NR1, NR2); at line 60.

Now, if you peek definition for VALIDATE_DATES you will get no definition found message.

Try rename PROCEDURE "VALIDATE_DATES" to PROCEDURE VALIDATE_DATES (just delete double quotations), then peek definition works.

zabel-xyz commented 5 years ago

Thanks for the sample. This is currently not supported by regExpParser neither by .tmLanguage (colorization failed too) I'll fix to support this feature.

zabel-xyz commented 5 years ago

Fix in version 1.7.0