search

zabel-xyz / plsql-language

plsql-language for vscode
MIT License
78 stars 28 forks source link

Navigation does not work with regexp #74

Closed StefanRoess closed 5 years ago

StefanRoess commented 5 years ago

I use the current version (1.7) of xyz on a windows host. I have opened, for example .pkb PL/SQL File. The navitagion via CTRL+P and ALT-GR+@ does not show all procs and funcs. The reason is the regexp_ function, which is inside of another function. In my case, i use regexpcount..., but also any other regexp* function caused in a break for showing all funcs/procs in the navigation window.

Any reason why?

zabel-xyz commented 5 years ago

Can you give me an example ? In order to reproduce your issue. (The latest version is 1.8.1)

StefanRoess commented 5 years ago

image

The newest version seems to be 1.7, look at the picture, there is the german word "Aktuell" means current.

image

And here is an example. You can see only three procs/funcs. But in reality i have much more in my package. image

The reason is the regexp_count function: image

all the following funcs/procs will not displayed in the overview listing: image Only the first three proc/func. With the appearance of the first regexp_* function inside a proc/func all the following won't appear.

Do you have any idea? As soon as i removed all kind of regexp_* all funcs and procs will be displayed. Strange behaviour.

zabel-xyz commented 5 years ago

Thanks for the example, The last published version is 1.8.1 => update your vscode version.

You find a bug, The problem here is not regexp_ but variable pi_case, As soon as I rename it to pi_cse, all funtions will be displayed. I guess there is a confusion in regExParser with keyword case.

I'll fix it...

zabel-xyz commented 5 years ago

Fix in version 1.8.2

StefanRoess commented 5 years ago

Thank you for fixing the regexp issue. Right now, after all updates and your fixing it works.