search

zabi94 / ExtraAlchemy

Extra Alchemy: a Minecraft mod that expands on potions
Other
38 stars 16 forks source link

Potion Rings don't work in Inventorio's additional slots #110

Closed JumperREDACTED closed 3 years ago

JumperREDACTED commented 3 years ago

Describe the bug Potion Ring's don't activate if placed into Inventorio's additional slots. (Either slots gained from the deep pocket enchantment, or the additional offhand slots.) https://github.com/Lizard-Of-Oz/Inventorio/issues/31

Pastebin links

Environment (please complete the following information):

zabi94 commented 3 years ago

Potion rings only work in ticking slots, inventorio must implement item ticking in its logic to be compatible

zabi94 commented 3 years ago

Problem is, inventory ticking is not as straightforward to add as one might think. Many mods would probably crash or work weirdly, because they must be supplied with the inventory slot, but there is no way of telling the item what inventory to look in.

As a result, telling the item it is in slot 1 might cause the item's mod to look into the vanilla inventory slot 1, belonging to another item

Lizard-Of-Oz commented 3 years ago

Inventorio author here. I'll implement an API for custom Inventorio ticking in a day or two (and some extra functionality for that matter). It won't make things magically work with all mods, but will allow other mods to call Inventorio's item ticking, like with Trinkets or Curios.

zabi94 commented 3 years ago

Works for me. I'll subscribe to the issue on your side to be notified when it closes, I'll close this one

zabi94 commented 3 years ago

Implemented in 1.17 alpha build. I couldn't do 1.16.4 because of a temporary problem (terraformersMC maven repo being down, used for many dependencies in ea), but I hope they will fix it by next week