search

zabi94 / ExtraAlchemy

Extra Alchemy: a Minecraft mod that expands on potions
Other
38 stars 16 forks source link

ability to change what the growth potions do #116

Closed EmoBubbleGum closed 2 years ago

EmoBubbleGum commented 3 years ago

these potions are really fun, but the effects are overkill. i'd like to get the best of both worlds, and have a way to config the insane amount of reach these potions give players.

zabi94 commented 3 years ago

What would you want to change? The size?

EmoBubbleGum commented 3 years ago

size and speed for shrink/grow would be great too, but i was mainly thinking about that reach, grow lets you attack and break blocks 30+ blocks away atm. i'd personally only like it to extend reach by a few blocks, but that's my preference. seems like something that would be good to be adjustable.

zabi94 commented 3 years ago

I use Pehkui's general reaizing. The default values are dictated by the library, I only decide a generic muliplicator and everything grows according to its rules.

I could tune them one by one, but the amount of work is just not worth it for the moment. I'll leave this issue open, to let other people give their input on the matter, and consider it if it becomes a shared opinion

EmoBubbleGum commented 3 years ago

ahhh so at least for now i can bandaid fix most of the issues by editing the pehkui config. i appreciate this information

zabi94 commented 3 years ago

I wasn't even aware the library allowed that config

EmoBubbleGum commented 3 years ago

it does, but i am really not sure how to edit these values, lol. image changing the max to 1.7028234663852886E38 didnt seem to do much.

EmoBubbleGum commented 3 years ago

image tried completely disabling scaledreach and scaledattack, it had no effect.

EmoBubbleGum commented 3 years ago

so as a quick update, it's the same issue with the commands that change size. so it's not an issue with your mod. it's either pehkui, or this modpack... annoying

EmoBubbleGum commented 3 years ago

javaw_HWyUvOoyQ6 last update for now, a picture to emphasize the reach being large gives you for attacks (see the tree in the distance). i made a github issue with pehkui, hopefully gives some answers. though, it might be a good idea to change this for your mod by default, as it pretty badly breaks growth II potions, to be able to melee from 40 meters away

zabi94 commented 3 years ago

Any news from pehkui side? Is this issue still relevant?

EmoBubbleGum commented 3 years ago

well, the scale change doesn't let you break blocks across the map anymore, but it's still really overkill, and disabling reach scaling in pehkui does nothing.