zabi94 / ExtraAlchemy

Extra Alchemy: a Minecraft mod that expands on potions
Other
38 stars 16 forks source link

Datapack not works. #123

Closed seriousfreezing closed 3 years ago

seriousfreezing commented 3 years ago

Describe the bug I copied the whole datapack structure into github itself and it didn't work.

To Reproduce Steps to reproduce the behavior:

  1. Go to folder "datapacks" on your map.
  2. Paste the "ExtraAlchemy/src/main/resources/data/extraalchemy/recipes" inside the datapack folder.

Expected behavior It was supposed to change the values of the potion rings, but even changing .json changes nothing.

Screenshots If applicable, add screenshots to help explain your problem.

Pastebin links Don't paste the whole lists here, use pastebin

Environment (please complete the following information):

Additional context idk.

zabi94 commented 3 years ago

Are you placing the jsons in the folder or are you using an actual zip datapack?

seriousfreezing commented 3 years ago

Is in the folder.

seriousfreezing commented 3 years ago

image

zabi94 commented 3 years ago

Those need to go into an actual datapack. There are plenty of tutorials online like this one

seriousfreezing commented 3 years ago

image But, I've been to this link, I've been to datapack documentations.

I believe the actual structure is correct, I believe it is non-functional .jsons

zabi94 commented 3 years ago

Is it a zip file then?

seriousfreezing commented 3 years ago

No.

zabi94 commented 3 years ago

Are you capable of changing vanilla recipes without making it a zip?

seriousfreezing commented 3 years ago

Dude, understand there is no .zip or .rar or .7zip

In the datapack folder there are only folders and .jsons.

zabi94 commented 3 years ago

I don't understand what the issue is then. You made something that's not supposed to work, and it's not working. I'm clearly missing something here

seriousfreezing commented 3 years ago

Well, do you want me to send the datapack in .zip for you to analyze?

zabi94 commented 3 years ago

I feel like you don't understand what I'm saying, or I am not understanding the problem.

Here's what I understand: you put loose json files into the datapack folder and you're complaining they are not working.

I said that for any ring recipe json to work, they MUST be part of a zip datapack.

You said there were no zips, so I linked the guide on how to create one in a valid datapack format.

You said you read that but you believe it is a json format issue.


Send me the datapack, yes. I feel like it will be easier to understand for both

seriousfreezing commented 3 years ago

ExtraAlchemy.zip

Well, if the problem is just putting the base folder in .zip then I'll test it and see if it works.

zabi94 commented 3 years ago

It's not just a zip. The link I posted earlier explains how to make a valid zip. You need to include other stuff.

I'll look at the zip sometime this week hopefully, I can't really do that sooner. Please update this if you can get it to work without me

seriousfreezing commented 3 years ago

Okay.. sorry for this.

zabi94 commented 3 years ago

No worries, it was just miscommunication.