search

zabi94 / ExtraAlchemy

Extra Alchemy: a Minecraft mod that expands on potions
Other
38 stars 16 forks source link

Made the brewing stand fire tweak configurable #144

Closed Similacrest closed 2 years ago

Similacrest commented 2 years ago

Made it so that you can set up in the settings the time delay for increasing the brewing stand fuel from heating (in seconds) and the maximum fuel limit you can get through heating.

For myself I find 300s delay and 1 fuel limit acceptable.

I've also backported this tweak and the latest changes in the repo (patchouli + proxy rework) to 1.18.2 if you'd like to release it there https://github.com/artem-mateush/ExtraAlchemy/tree/fabric-1.18.2

zabi94 commented 2 years ago

I haven't tested it, but does increasing the fuel beyond what's currently set as maximum in vanilla work fine? I'd assume anything above 20 is either reset to 20, or causes weirdness with the fuel texture going beyond the slot at least

Similacrest commented 2 years ago

Good point. Added a cap for 20. (Ideally there should be config/mod menu constraints, non-negative too - don't know how to do that yet).

zabi94 commented 2 years ago

Do you actually speak the languages you've translated to, or are they the result of an automated translator? In the latter case I'd rather not have them and let the original translators take care of them

zabi94 commented 2 years ago

Otherwise, the rest looks good. I'll merge when I'll manage to get some time

Similacrest commented 2 years ago

Do you actually speak the languages you've translated to, or are they the result of an automated translator? In the latter case I'd rather not have them and let the original translators take care of them

The Russian one is accurate, others I google-translated, so would be better to ping the translators indeed!

zabi94 commented 2 years ago

Actually, I'll just merge and apply the changes myself, I don't want to deal with conflicts later