zabi94 / ExtraAlchemy

Extra Alchemy: a Minecraft mod that expands on potions
Other
38 stars 16 forks source link

[Bug Report] Magnetism Disabled effect name not added in en_us.json #166

Closed Cicopath closed 3 months ago

Cicopath commented 3 months ago

Describe the bug Title. In-game, the name of the effect is "effect.extraalchemy,magnetism_disabled".

To Reproduce Steps to reproduce the behavior:

  1. Install JEI/REI/EMI
  2. Launch Minecraft and open up a world
  3. Give yourself the Magnetism Disabled effect and check the name of it in the inventory

Optionally, if you have Just Enough Effect Descriptions installed, you can search the JEI/REI/EMI menu for the effect instead, which is what I did.

Expected behavior The name of the effect should be "Magnetism Disabled".

Screenshots image

Pastebin links Don't paste the whole lists here, use pastebin

Environment (please complete the following information):

Additional context Add any other context about the problem here, like other mods that you think might be involved in the problem.

https://github.com/zabi94/ExtraAlchemy/blob/fabric-main/src/main/resources/assets/extraalchemy/lang/en_us.json. The effect also doesn't have a description (effect.extraalchemy.magnetism_disabled.description).

zabi94 commented 3 months ago

This must be a new feature of REI I wasn't aware of. "Magnetism disabled" is a stub effect and it is not meant to be used ever, I only use it to change the icon when you toggle the magnetism effect. I'll see if it is possible to actually remove it altogether from the list

zabi94 commented 3 months ago

Please, add the missing information for installed versions and mod list. This doesn't happen in a simple installation

Cicopath commented 3 months ago

Ahha, so this was an effect not meant to be seen! Explains a lot. What is shown in the screenshot is actually from an effect addon called "Just Enough Effect Description" (JEED for short), and it's meant to inform players on what certain effects do.

The way to configure the mod is essentially through the language file parameters I mentioned above, as well as a special recipe type that lists what items are related to the effect.

zabi94 commented 3 months ago

Is JEI available for fabric too now or is extra alchemy loaded through the forge connector?

Cicopath commented 3 months ago

Ack—forgot to put the loader and other details:

Loader & version Fabric 1.20.1-0.16.0

Mods REI 12.1.740 JEED 2.2.2 Extra Alchemy 1.10.0

JEED is actually compatible with JEI, REI, and EMI. You can read more about it here: https://www.curseforge.com/minecraft/mc-mods/just-enough-effect-descriptions-jeed.

I do have Sinytra Connector installed in this modpack, but that's for just one unrelated mod I believe? None of the mods listed above are loaded through it.

And, on top of that, turns out as of August 6, JEI is part of Fabric now surprisingly!: https://www.curseforge.com/minecraft/mc-mods/jei/files/all?page=1&pageSize=20&version=1.20.1&gameVersionTypeId=4

zabi94 commented 3 months ago

JEED doesn't seem to offer a way to blacklist effects, I can't do much.