search

zabirauf / icsharp

C# kernel for Jupyter
Other
278 stars 62 forks source link

Bring ICSharp up to date: refresh the installation instructions and upgrade scriptcs to fix failing NuGet restoration #32

Closed alexpolozov closed 7 years ago

alexpolozov commented 7 years ago

This PR includes two changes that bring ICSharp up to date. I had a hard time figuring out on my own how to build and use it since (a) all the instructions were outdated in different ways, and (b) the scriptcs dependency was broken.

1. Update scriptcs to its current master.

Most importantly, this fixes scriptcs#1171 by upgrading Nuget.Core to 2.14.0. I encountered the same error with multiple packages when I tried to use ICSharp with an outdated csriptcs dependency.

2. Refresh the installation instructions.

I updated the Windows installation page in the wiki and put a link there to README.md. The original instructions (with pip and chocolatey) are outdated. On that note, can we push a new pip/chocolatey package release?

P.S. The Travis build fails consistently, even in master. I don't have time to take a look at it right now, but some unit tests definitely need updates as well.

zabirauf commented 7 years ago

Thanks a lot @apskim for updating the Wiki and the README, this will be very helpful. The Travis build seems to be failing because of some test failures in ScriptCs. I think I'll just disable the tests for ScriptCs in the .travis.yml.

Regarding the new pip/chocolatey package, the scripts need to be updated as Chocolatey has changed bunch of things since last time the package was pushed. I was thinking that having a docker image would make it work across platform and will be much easier.