Improve ZMQ identity handling

thomasjm commented 7 years ago

This PR does a few things

Bump the NetMQ version to 4.0.0.1. The new API is nicer since you don't have to pass a NetMQContext around, and the socket methods are less confusing.
Modify the shell socket to properly conform to the Jupyter messaging wire protocol: http://ipython.org/ipython-doc/dev/development/messaging.html#the-wire-protocol. It needs to gracefully handle multiple ZMQ identity frames being present at the beginning of a message.
When sending an execute_reply message, it's necessary to send the ZMQ identity frames at the beginning, otherwise the message doesn't get sent at all. The normal Jupyter clients handle this gracefully which is probably why this wasn't noticed before.

zabirauf commented 7 years ago

@thomasjm thanks a lot for the pull request. I'm just taking a look at the changes.

zabirauf commented 7 years ago

The change looks good! I just have a single comment, if you can make that change then great, otherwise let me know I'll make the change after the merge.

thomasjm commented 7 years ago

Done, hopefully it builds

zabirauf commented 7 years ago

Thanks @thomasjm, I've merged the changes

thomasjm commented 7 years ago

Cool, thanks!

zabirauf / icsharp

Improve ZMQ identity handling #33