Wrong phone number when using sendSMS function

[vumail159951]

• The node-pdu library goes wrong when I try to send it to phone: 999 https://github.com/zabsalahid/serialport-gsm/blob/da3a7337ba2a787dda7e09c765831c8e43cb129d/lib/functions/modem.js#L670

Example send SMS:

• number: 999, message: Hello
• Expected PDU hex: 000100038199F9000005C8329BFD06
• Actual PDU hex: 000100039199F9000005C8329BFD06

// no bug code
const smsPdu = require('node-sms-pdu');

const number = '999'; // Telephone number (in this case, national number)
const message = 'Hello'; // Text

const pdu_list = smsPdu.generateSubmit(number, message);
console.log(pdu_list[0].hex);
// this return 000100038199F9000005C8329BFD06 {phone: "999"}

// bug code
const pdu = require('node-pdu');
let submit = pdu.Submit();

submit.setAddress(number);
submit.setData(message);

let parts = submit.getParts();
console.log(parts[0].toString());
// this return 000100039199F9000005C8329BFD06, {phone: "+999"}

using the old node-pdu, the function return error: CMS ERROR +8 Please review and use node-sms-pdu https://github.com/tiagfernandes/serialport-gsm

[KillerJulian]

I gues it's a bug from node-pdu and you should create the issue there too. I should also fix the bug in my version of node-pdu.

I believe that the project owner will not decide to switch to another library, as node-pdu offers more possibilities.

[vumail159951]

Thank you, I will edit the node-pdu to work around when waiting for the fix

[KillerJulian]

Hi, it was not a bug. The SCA type should be set manually. I have added a new feature with commit https://github.com/jackkum/node-pdu/pull/25/commits/14972ead2fb8dc05b99777c0f568629234a41669 that will set the SCA type be automatically for the address. Alternatively, I have added a function in my TypeScript rewrite that allows you to send your own submits (with cutom SCA types).

Currently, you have no possibility to correct the "error" with this library

[KillerJulian]

@vumail159951 your issue will be fixed if the owner of this library update the node-pdu version to 2.0.0 or better he want merge my pull request