getNetworkSignal() does not return any data

[zabsalahid]

Hey @karianpour !

Upon checking, getNetworkSignal does not return and had resulted to timeout.

item.logic = (newpart) => {
      let resultData;
      if (newpart.substr(0, 5) == '+CSQ:') {
        let signal = newpart.split(' ')
        signal = signal[1].split(',')
        resultData = {
          status: 'success',
          request: 'getNetworkSignal',
          data: { 'signalQuality': signal[0] }
        }
      }
      if ((newpart == ">" || newpart == "> " || newpart == 'OK') && resultData) {
        return {
          resultData,
          returnResult: true,
        }
      } else if (newpart == "ERROR") {
        return {
          resultData: {
            status: 'ERROR',
            request: 'getNetworkSignal',
            data: 'Cannot Get Signal'
          },
          returnResult: true,
        }
      }
    }

resultData is always set to undefined every time item.logis() is called, will not enter

((newpart == ">" || newpart == "> " || newpart == 'OK') && resultData)

part.

[karianpour]

I see the bug, the variable should be defined out side of the function to let the closure hold the data. Tonight I will fix it.

[karianpour]

@zabsalahid I made a pull request for it.