search

zabsalahid / serialport-gsm

SerialPort-GSM is a simplified plugin for communicating with gsm modems. (Primarily for sms) (Focused in PDU mode)
MIT License
90 stars 47 forks source link

Breaking change: change callbacks to use "err first responses" (as usual in JS) #55

Closed Apollon77 closed 4 years ago

Apollon77 commented 4 years ago

@zabsalahid what do you think?

zabsalahid commented 4 years ago

@zabsalahid what do you think?

I agree with this. Just like the usual JS. But for me personally, my callback return is err first. And the early codes for this proj was too.

Apollon77 commented 4 years ago

Ok, I hope I find time soon to continue with this project ... then I update it that way

Apollon77 commented 4 years ago

You can assign it to me

zabsalahid commented 4 years ago

Ok, I hope I find time soon to continue with this project ... then I update it that way

I'm too busy, can't find time to update yet. Thanks @Apollon77 .

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

zabsalahid commented 4 years ago

enhancement

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Apollon77 commented 4 years ago

planned

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Apollon77 commented 4 years ago

planned

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Apollon77 commented 4 years ago

@zabsalahid Please reopen and flag so that it is not handled by stalebot again. Thank you!