search

zabsalahid / serialport-gsm

SerialPort-GSM is a simplified plugin for communicating with gsm modems. (Primarily for sms) (Focused in PDU mode)
MIT License
90 stars 47 forks source link

Promise support for all of the methods #6

Closed karianpour closed 5 years ago

karianpour commented 5 years ago

I like this library. And I like to use async/await style coding. Most of the methos in modem class does not support them, do you agree to implement them? I can do it. If yes, do you like to have the backward compatibility, or you prefer to change a major version and have callback argument as the last one on each method?

karianpour commented 5 years ago

I provided a draft pull request. If you agree or you have comment let me know to process.

zabsalahid commented 5 years ago

@karianpour let's give it a go. Also, been thinking about implementing async/await. Since we should be moving forward, I'd say yes, but it should have backward compatibility.