search

zabsalahid / serialport-gsm

SerialPort-GSM is a simplified plugin for communicating with gsm modems. (Primarily for sms) (Focused in PDU mode)
MIT License
90 stars 47 forks source link

changed serial port API to support promise based API #67

Closed theanam closed 4 years ago

theanam commented 4 years ago

Since the serialport library does not support callbacks in the list function, it causes the application to throw an error. I've replaced the list function to support the new promise based API

Apollon77 commented 4 years ago

LGTM, seems we missed that change by the serialport upgrade

zabsalahid commented 4 years ago

@theanam it supports callback or promise image

theanam commented 4 years ago

That I've noticed. but the library serialport does not support callbacks anymore. try removing your node modules and lockfile and reinstall dependencies in your development environment and then try running the list function in serialport-gsm. It should throw and error.

zabsalahid commented 4 years ago

I've checked it. Thank you @theanam !