search

zabuldon / teslajsonpy

Apache License 2.0
56 stars 62 forks source link

fix: correct typo in wake_up call #383

Closed carleeno closed 1 year ago

carleeno commented 1 year ago

Fix a bug introduced in #379

carleeno commented 1 year ago

@alandtse sorry about this, I totally missed it. Fortunately it's not common to reach this line of code (the car has to have gone offline since the last update when sending a command). But we probably should point release teslajsonpy for this fix before we release 3.5.0 because with enough users out there, we will see this bug pop up.

alandtse commented 1 year ago

I'm on mobile so can't create a PR. Can you do a PR from Dev to master please? I just date those and ignore the semantic versioning requirement.

carleeno commented 1 year ago

I'm on mobile so can't create a PR. Can you do a PR from Dev to master please? I just date those and ignore the semantic versioning requirement.

Unfortunately it seems I'm blocked from making a PR against master. however the tesla integration doesn't have this bug yet, so it probably doesn't have to be rushed, I just wanted to make sure you saw this before cutting the next tesla integration release.