zabuldon / teslajsonpy

Apache License 2.0
56 stars 62 forks source link

fix: Use the correct location for `vehicle_config`. (#462) #463

Closed kbrint closed 6 months ago

kbrint commented 6 months ago

I tried patching in the test only (to the previous dev branch) and they still all pass.

I think that is a separate bug, and that's possibly how this error slipped into the code in the first place.

alandtse commented 6 months ago

Thanks. I mean it's weird cause it reverts the prior change but we can see if it results in a revert war.

kbrint commented 6 months ago

Thanks. I mean it's weird cause it reverts the prior change but we can see if it results in a revert war.

The change in question (92774e9) modifies references to:

It appears that the vehicle_config contains immutable attributes of the vehicle (as opposed to the *_state entries). I don't think it needs to be refreshed often, nor should the values change if the car is offline. Anyway, this is where the data actually is.