Closed kbrint closed 6 months ago
Thanks. I mean it's weird cause it reverts the prior change but we can see if it results in a revert war.
Thanks. I mean it's weird cause it reverts the prior change but we can see if it results in a revert war.
The change in question (92774e9) modifies references to:
vehicle_config
(the subject of this PR), andvehicle_state
, andclimate_state
.It appears that the vehicle_config
contains immutable attributes of the vehicle (as opposed to the *_state
entries). I don't think it needs to be refreshed often, nor should the values change if the car is offline. Anyway, this is where the data actually is.
I tried patching in the test only (to the previous dev branch) and they still all pass.
I think that is a separate bug, and that's possibly how this error slipped into the code in the first place.