zabuldon / teslajsonpy

Apache License 2.0
57 stars 62 forks source link

unhandled error #475

Open gjaegy opened 3 months ago

gjaegy commented 3 months ago

Hi,

I'm not sure if that's the correct place to post, however, looking at the callstack, I guess it might be. If not please simply ignore my message.

I'm facing a problem where my automation stops randomly, when a command can't be issued for whatever reason (in most cases, rare random network issue/time out).

See the following post for a description of the original problem, as well as some answer describing the reason of the automation stopping, despite using the "continue_on_error" option for my action call:

https://github.com/home-assistant/core/issues/123296

In a nutshell, the reason of "continue_on_error" not working is due to some exception not being handled. From what I've understood (could be wrong), the library should catch the http exception, and raise a defined exception when caught.

This is explained in the following HA core issue answer : https://github.com/alandtse/tesla/issues/1015

I'm using https://github.com/alandtse however it seems this library uses teslajsonpy under the hood, so I'm not fully sure at what level this should be fixed (I'm not familiar with HA development I must admit).

Any idea how this could be fixed ?

Thanks a lot !!