search

zabuldon / teslajsonpy

Apache License 2.0
57 stars 62 forks source link

fix: json attribute error for GET with parameters #477

Closed ehendrix23 closed 1 week ago

ehendrix23 commented 1 week ago

When doing an API call for which the method is get but where parameters are provided an exception occurs for unknown attribute json=data. This is due to the httpx get method not supporting the json parameter, instead the params parameter has to be provided.

This fixed checks if the method is get and if it is will provide the additional parameters through params parameter instead.

ehendrix23 commented 1 week ago

Fixed the title issue.

Not sure why 3.10 failed the test as I do not see how my small change would cause it to fail.