Misplaced compound_l1_mssim_loss

zaccharieramzi / fastmri-reproducible-benchmark

Try several methods for MRI reconstruction on the fastmri dataset. Home to the XPDNet, runner-up of the 2020 fastMRI challenge.

https://fastmri.org/leaderboards

MIT License

151 stars 50 forks source link

Misplaced compound_l1_mssim_loss #143

Open Daval-G opened 3 years ago

Daval-G commented 3 years ago

The function named compound_l1_mssim_loss is currently defined in models/training/compile.py which is not really intuitive. I would expect it to be defined along with other loss functions at evaluate.metrics.tf_metrics.py or simply in evaluate.metrics.

zaccharieramzi commented 3 years ago

Good point. I would rather have a new file, losses.py where we could define this, because the compound mssim is not really a metric per se.