tensorflow-addons needs an update in requirements.txt

zaccharieramzi / fastmri-reproducible-benchmark

Try several methods for MRI reconstruction on the fastmri dataset. Home to the XPDNet, runner-up of the 2020 fastMRI challenge.

https://fastmri.org/leaderboards

MIT License

151 stars 50 forks source link

tensorflow-addons needs an update in requirements.txt #149

Closed ogrisel closed 3 years ago

ogrisel commented 3 years ago

At the moment, pip install -r requirements.txt fails with:

ERROR: Could not find a version that satisfies the requirement tensorflow-addons==0.9.1 (from versions: 0.10.0, 0.11.0, 0.11.1, 0.11.2, 0.12.0, 0.12.1, 0.13.0, 0.14.0)
ERROR: No matching distribution found for tensorflow-addons==0.9.1

(using Python 3.8 on Linux amd64).

ogrisel commented 3 years ago

This works:

diff --git a/requirements.txt b/requirements.txt
index 3b221d6..604c599 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -6,7 +6,7 @@ runstats
 nibabel
 Pillow
 tensorflow == 2.4
-tensorflow-addons == 0.9.1
+tensorflow-addons >= 0.9.1
 click
 tfkbnufft >= 0.1.2
 pandas

it installs 0.14.0 but then I am not 100% everything works with this.

zaccharieramzi commented 3 years ago

Thanks for pointing it out! I am surprised that the CI didn't catch it, but I am happy having a relaxed version. Do you want to submit a PR or should I?

ogrisel commented 3 years ago

I can do that.

zaccharieramzi commented 3 years ago

Closing after your PR #152