search

zaccharieramzi / fastmri-reproducible-benchmark

Try several methods for MRI reconstruction on the fastmri dataset. Home to the XPDNet, runner-up of the 2020 fastMRI challenge.
https://fastmri.org/leaderboards
MIT License
151 stars 50 forks source link

maybe remove or update np_metrics #150

Closed chaithyagr closed 2 years ago

chaithyagr commented 3 years ago

Currently, skimage has updated the location for metrics in 0.18.3. Things work fine with 0.17.2.

Howoever, this causes import issues even if the user does not use it

chaithyagr commented 3 years ago

The fiile is here: https://github.com/zaccharieramzi/fastmri-reproducible-benchmark/blob/master/fastmri_recon/evaluate/metrics/np_metrics.py

zaccharieramzi commented 3 years ago

Thanks for pointing it out! Do you want to submit a PR for it or should I?

chaithyagr commented 3 years ago

i think i can handle a PR, but do you want it to stay or removed?

zaccharieramzi commented 3 years ago

I want the metrics to stay, but we can just update their import and have scikit-image be of version at least 0.18.3