search

zaccharieramzi / fastmri-reproducible-benchmark

Try several methods for MRI reconstruction on the fastmri dataset. Home to the XPDNet, runner-up of the 2020 fastMRI challenge.
https://fastmri.org/leaderboards
MIT License
151 stars 50 forks source link

need to specify the scikit-image version in the requirements.txt #151

Closed fachra closed 3 years ago

fachra commented 3 years ago

Hello,

The function compare_psnr could be moved to another place in the latest version (0.18) of scikit-image. So the code below will raise an error with the latest skimage. https://github.com/zaccharieramzi/fastmri-reproducible-benchmark/blob/f18a4f7d7fdfcc08fd28c84f2bed8dbdedab4a9a/fastmri_recon/evaluate/metrics/np_metrics.py#L10

Need to specify the version (0.17.2) in the requirements.txt. https://github.com/zaccharieramzi/fastmri-reproducible-benchmark/blob/f18a4f7d7fdfcc08fd28c84f2bed8dbdedab4a9a/requirements.txt#L3

Best, Chengran

zaccharieramzi commented 3 years ago

Hi Chengran,

Thanks for pointing it out! Do you want to submit a PR for it or should I?

I think btw it's a duplicate with #150

fachra commented 3 years ago

Yes, it duplicates with #150. I will close this one.