search

zaccharieramzi / fastmri-reproducible-benchmark

Try several methods for MRI reconstruction on the fastmri dataset. Home to the XPDNet, runner-up of the 2020 fastMRI challenge.
https://fastmri.org/leaderboards
MIT License
151 stars 50 forks source link

Add support for tensorflow-nufft #176

Closed chaithyagr closed 2 years ago

chaithyagr commented 2 years ago

This PR adds supports for tensorflow-nufft through the same interface. We also bump up the tensorflow version to the latest

chaithyagr commented 2 years ago

Speedup of nearly 7-8 x with this library...

chaithyagr commented 2 years ago

The test may not work as it needs CUDA and a GPU if I am right... I can have one which can run locally when needed..

zaccharieramzi commented 2 years ago

Yes even a local test is great!

zaccharieramzi commented 2 years ago

And can you make sure to have all tests green ?

chaithyagr commented 2 years ago

Lol yes on it. No idea what these errors are. Mostly it's due to the switch to tf 2.8

chaithyagr commented 2 years ago

This mostly shall make it green. I had good tests locally. I will add some quick tests now for tfnufft checks

chaithyagr commented 2 years ago

Removed, and added tensorflow-nufft. @zaccharieramzi can you recheck if you are happy with the new flow to test if we are on CI and then run / not run tensorflow-nufft implementation?

chaithyagr commented 2 years ago

The tests passed earlier, just have a gitignore update. @zaccharieramzi this can be merged and can you please make a new release as well?

chaithyagr commented 2 years ago

Ahhh missed your comment, on it