search

zaccharieramzi / tfkbnufft

A robust, easy-to-deploy non-uniform Fast Fourier Transform in TensorFlow.
MIT License
30 stars 5 forks source link

[URGENT] Test fails but CI reports a pass #39

Closed chaithyagr closed 3 years ago

chaithyagr commented 3 years ago

CI reports a pass while the pytest actually reported a fail. This could miss some crucial issues. An example for this is :

https://github.com/zaccharieramzi/tfkbnufft/pull/38/checks?sha=4b18de94d6b40e14ce1f7e14e3e80e5c5da7052b

We may need to move to setting up a test CI which is stronger.

zaccharieramzi commented 3 years ago

The example is gone now, do you have a screenshot by any chance? or do you remember which run exactly it was?

chaithyagr commented 3 years ago

Oh nope, no screenshot. Let me see, I think it should still esxist. Will post screenshot. The test was dcomp test

chaithyagr commented 3 years ago

It seems to still be there...

image

image

zaccharieramzi commented 3 years ago

I see this is because we run both in the same sh file, and it outputs the last info

I think we should have a set -x or something like that. Let me see.