zacchiro / beangrep

Beangrep - grep-like filter for Beancount
GNU General Public License v2.0
11 stars 2 forks source link

Allow options to be set via environment variables (to override defaults) #21

Closed hoostus closed 3 months ago

hoostus commented 3 months ago

Enable click's auto_envvar_prefix to fix #8

I added a few tests and updated the README.

Let me know if you see anything else you want changed for this PR.

Cheers, Justus

zacchiro commented 3 months ago

Hello, thanks a lot, this looks great!

I've very minimally reworked your commits in the envvar branch to merge related commits together and adapted the commit message style to be more consistent with previous commits. I've also added a commit of mine clarifying how boolean options map to envvar values, because that was not clear to me.

Can you please take a look and confirm you're OK with me merging that branch into main? If so, we'll be soon done here! Thanks again.

hoostus commented 3 months ago

Yep, looks good to me.

zacchiro commented 3 months ago

Merged into main with 5a44873db73901a4a06cb060964e875444de58b2.