search

zacchiro / beangrep

Beangrep - grep-like filter for Beancount
GNU General Public License v2.0
11 stars 2 forks source link

Use custom logger (instead of root logger). #23

Closed hoostus closed 2 months ago

hoostus commented 2 months ago

This fixes #17 which (I assume) was caused by click's CliRunner configuring the root logger in its own way before beangrep ran.

Our custom logger is "beangrep.cli" (i.e. just name from cli.py). Includes some unit tests to ensure it works as expected.

zacchiro commented 2 months ago

Thanks a lot for this, which looks promising, and indeed fix the test suite coverage issue.

However, when using this, --verbose on the CLI is broken for me. It seems to be completely ignored (i.e., it does not increase verbosity), whereas it works just fine in the main branch right now. Have you tried it yourself? (Outside of the test suite, I mean.) Does it work for you? I have not debugged it further for now.

hoostus commented 2 months ago

I was 98% sure that I had tested it outside of the test suite but you're right it doesn't work. I notice that the call to logging.basicConfig was inadvertently removed by me at some point. I've added that back in, which fixes the cli breakage you noticed.

On Friday, August 9th, 2024 at 4:36 PM, Stefano Zacchiroli @.***> wrote:

Thanks a lot for this, which looks promising, and indeed fix the test suite coverage issue.

However, when using this, --verbose on the CLI is broken for me. It seems to be completely ignored (i.e., it does not increase verbosity), whereas it works just fine in the main branch right now. Have you tried it yourself? (Outside of the test suite, I mean.) Does it work for you? I have not debugged it further for now.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

zacchiro commented 2 months ago

Awesome, I confirm it works for me too. Merged!