zach-capalbo / flammarion

The nifty ruby gui toolkit.
Other
285 stars 11 forks source link

Apps close exit after start #24

Closed jwoertink closed 8 years ago

jwoertink commented 8 years ago

Just testing this out, I made a file.

# app.rb
Flammarion.about

Then I ran ruby app.rb, and a dialog opened, then closed and the whole app exited with

[23:43PM] 404app3$ ruby app.rb 
(electron) companyName is now a required option to crashReporter.start
(electron) loadUrl is deprecated. Use loadURL instead.
[23:44PM] 404app3$ 

I was able to circumvent this by adding a

Flammarion.about
while true
end

This seems to be the case for the examples in the README as well.

zach-capalbo commented 8 years ago

Thanks for bringing this up! I've changed the about method to block (by calling wait_until_closed) and updated the Readme to try to make it a little more clear.

Addressed in v0.1.5

jwoertink commented 8 years ago

Ah, ok. Awesome. Just updated, and I see those updates. Thanks!