search

zach-m / jonix

Commercial-grade library for extracting data from ONIX sources
Apache License 2.0
57 stars 17 forks source link

Typo for BISAC subject code #34

Closed Green-Beret closed 7 months ago

Green-Beret commented 8 months ago

lots of classes, methods with this subject is called BASIC. Such as com.tectonica.jonix.onix2.BASICMainSubject, com.tectonica.jonix.onix2.Product.basicVersion() etc.

zach-m commented 7 months ago

all the code, and particularly class names, is generated from the Onix specifications directly. As the tag name in Onix is <BASICMainSubject>, the class name follows.

EDItEUR have commented in the past about this specific mix-up:

Note that the data element reference name was assigned during a period when the BISAC name had been changed to “BASIC”.
The name has now officially reverted to “BISAC”, but the ONIX data element name cannot be changed for reasons of upwards compatibility.